Skip to content

Commit

Permalink
fix up test for new deps
Browse files Browse the repository at this point in the history
  • Loading branch information
phryneas committed Dec 18, 2024
1 parent e0dbe98 commit 5bacf2e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,10 @@ test.describe("PreloadQuery", () => {
await expect(page).toBeInitiallyLoading(true);

await page.waitForEvent("pageerror", (error) => {
// this changed with Next 15 and seems like a bug in Next or React?
return error.message === "undefined";
// return (
// /* prod */ error.message.includes("Minified React error #419") ||
// /* dev */ error.message.includes("Query failed upstream.")
// );
return (
/* prod */ error.message.includes("Minified React error #419") ||
/* dev */ error.message.includes("Query failed upstream.")
);
});

await expect(page.getByText("loading")).not.toBeVisible();
Expand Down
6 changes: 3 additions & 3 deletions integration-test/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ __metadata:
linkType: hard

"@apollo/client-react-streaming@exec:./shared/build-client-react-streaming.cjs::locator=%40integration-test%2Froot%40workspace%3A.":
version: 0.11.7
version: 0.11.8-alpha.1
resolution: "@apollo/client-react-streaming@exec:./shared/build-client-react-streaming.cjs#./shared/build-client-react-streaming.cjs::hash=4f1b75&locator=%40integration-test%2Froot%40workspace%3A."
dependencies:
ts-invariant: "npm:^0.10.3"
Expand Down Expand Up @@ -81,10 +81,10 @@ __metadata:
linkType: hard

"@apollo/experimental-nextjs-app-support@exec:./shared/build-experimental-nextjs-app-support.cjs::locator=%40integration-test%2Froot%40workspace%3A.":
version: 0.11.7
version: 0.11.8-alpha.1
resolution: "@apollo/experimental-nextjs-app-support@exec:./shared/build-experimental-nextjs-app-support.cjs#./shared/build-experimental-nextjs-app-support.cjs::hash=db9e8a&locator=%40integration-test%2Froot%40workspace%3A."
dependencies:
"@apollo/client-react-streaming": "npm:0.11.7"
"@apollo/client-react-streaming": "npm:0.11.8-alpha.1"
peerDependencies:
"@apollo/client": ^3.10.4
next: ^13.4.1 || ^14.0.0 || ^15.0.0-rc.0
Expand Down

0 comments on commit 5bacf2e

Please sign in to comment.