Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce bundle size by adjusting imports #161

Merged
merged 4 commits into from
Jan 5, 2024
Merged

reduce bundle size by adjusting imports #161

merged 4 commits into from
Jan 5, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jan 3, 2024

This should especially tree-shake a large part of the graphql package that showed up in #126 (comment)

@phryneas
Copy link
Member Author

phryneas commented Jan 3, 2024

/release:pr

Copy link
Contributor

github-actions bot commented Jan 3, 2024

A new release has been made for this PR. You can install it with npm i @apollo/experimental-nextjs-app-support@0.0.0-commit-12fa821.

} from "@apollo/client";
import type { QueryManager } from "@apollo/client/core/QueryManager";
import { print } from "graphql";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what apparently has the big bundle size impact, as for some reason that's not tree-shaken by Next.js otherwise.

@phryneas phryneas marked this pull request as ready for review January 5, 2024 10:45
@phryneas phryneas requested a review from a team as a code owner January 5, 2024 10:45
@phryneas phryneas merged commit 10fc3e5 into main Jan 5, 2024
10 checks passed
@phryneas phryneas deleted the pr/reduce-size branch January 5, 2024 10:45
@phryneas
Copy link
Member Author

phryneas commented Jan 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant