Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.10.0 (1) - Throw error when passing arguments into getClient. #203

Merged
merged 7 commits into from
Apr 4, 2024
Merged

0.10.0 (1) - Throw error when passing arguments into getClient. #203

merged 7 commits into from
Apr 4, 2024

Conversation

phryneas
Copy link
Member

It has come again and again that people are trying to do this, so we should be more strict about the fact that this is not supported.

Happy for any wording suggestions.

@phryneas phryneas requested a review from a team as a code owner February 19, 2024 13:08
@phryneas phryneas changed the title Throw error when passing arguments into getClient. [idea] Throw error when passing arguments into getClient. Feb 19, 2024
jerelmiller
jerelmiller reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solid, quality of life improvement!

packages/client-react-streaming/src/registerApolloClient.tsx Outdated Show resolved Hide resolved
jerelmiller
jerelmiller approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@phryneas phryneas added this to the 0.10.0 milestone Feb 27, 2024
@phryneas phryneas force-pushed the pr/getClient-forceNoParameters branch from 4c1330e to 407204a Compare March 1, 2024 15:32
@phryneas phryneas changed the title [idea] Throw error when passing arguments into getClient. 0.10.0 (1) - Throw error when passing arguments into getClient. Mar 1, 2024
@phryneas phryneas changed the base branch from main to pr/integration-vitest March 1, 2024 16:46
jerelmiller
jerelmiller approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Base automatically changed from pr/integration-vitest to pr/integration-jest March 6, 2024 10:19
@phryneas phryneas deleted the branch main March 6, 2024 10:47
@phryneas phryneas closed this Mar 6, 2024
@phryneas
Copy link
Member Author

phryneas commented Mar 6, 2024 •
edited
Loading

Uhh, wtf. deleted the parent branch and now this is closed 🤦

This will need some serious rebasing later...

@phryneas phryneas reopened this Mar 6, 2024
@phryneas phryneas force-pushed the pr/getClient-forceNoParameters branch from 0abc532 to d06e3c2 Compare March 6, 2024 11:39
@phryneas phryneas changed the base branch from pr/integration-jest to main March 6, 2024 11:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024 •
edited
Loading

size-limit report 📦

Path Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM) 7.79 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.41 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 6.27 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.14 KB (0%)
@apollo/client-react-streaming (SSR ESM) 1.74 KB (0%)
@apollo/client-react-streaming (RSC ESM) 1.12 KB (+10.15% 🔺)
@apollo/client-react-streaming/manual-transport (Browser ESM) 6.46 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 6.34 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM) 8.41 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM) 8.33 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM) 857 B (0%)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 406 B (+46.05% 🔺)

@relativeci RelativeCI
Copy link

relativeci bot commented Mar 26, 2024 •
edited
Loading

Job #103: Bundle Size — 1.01MiB (0%).

96db8ed(current) vs fd40453 main#99(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  no changes
                 Current
Job #103		      Baseline
Job #99
No change  Initial JS 890.59KiB 890.59KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0.03% 0.03%
No change  Chunks 24 24
No change  Assets 45 45
No change  Modules 512 512
No change  Duplicate Modules 30 30
No change  Duplicate Code 1.29% 1.29%
No change  Packages 29 29
No change  Duplicate Packages 1 1
Bundle size by type  no changes
                 Current
Job #103		      Baseline
Job #99
Not changed  JS 1023.85KiB 1023.85KiB
Not changed  Other 5.99KiB 5.99KiB

View job #103 report View pr/getClient-forceNoParameters branch activity View project dashboard

@phryneas phryneas merged commit e0b4862 into main Apr 4, 2024
16 checks passed
@phryneas phryneas deleted the pr/getClient-forceNoParameters branch April 4, 2024 09:19
@denysmiand denysmiand mentioned this pull request May 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phryneas @jerelmiller