0.10.0 (4) default connectToDevTools
to false
in RSC and SSR builds
#271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #238
The last PR for 0.10.0.
This defaults
connectToDevTools
tofalse
in RSC and SSR builds where connecting to the DevTools is impossible anyways, but might end up in a straysetTimeout
that hangs around for 10 seconds which uses memory unneccessarily - and e.g. prevents tests from cleaning up correctly.No tests for this since I'm not sure how correctly to test this - but I could remove a few
connectToDevTools
from our tests, which is nice. I looked at the built artefacts though, and it's picked up correctly.