Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.0 (4) default connectToDevTools to false in RSC and SSR builds #271

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Apr 4, 2024

closes #238

The last PR for 0.10.0.

This defaults connectToDevTools to false in RSC and SSR builds where connecting to the DevTools is impossible anyways, but might end up in a stray setTimeout that hangs around for 10 seconds which uses memory unneccessarily - and e.g. prevents tests from cleaning up correctly.

No tests for this since I'm not sure how correctly to test this - but I could remove a few connectToDevTools from our tests, which is nice. I looked at the built artefacts though, and it's picked up correctly.

@phryneas phryneas requested a review from a team as a code owner April 4, 2024 10:26
@phryneas phryneas added this to the 0.10.0 milestone Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

size-limit report 📦

Path Size
{ ApolloNextAppProvider, NextSSRApolloClient, NextSSRInMemoryCache } from '@apollo/experimental-nextjs-app-support/ssr' (Browser ESM) 7.78 KB (0%)
{ WrapApolloProvider, ApolloClient, InMemoryCache } from '@apollo/client-react-streaming' (Browser ESM) 1.4 KB (0%)
{ buildManualDataTransport } from '@apollo/client-react-streaming/manual-transport' (Browser ESM) 6.27 KB (0%)
@apollo/client-react-streaming (Browser ESM) 2.13 KB (0%)
@apollo/client-react-streaming (SSR ESM) 1.75 KB (+0.96% 🔺)
@apollo/client-react-streaming (RSC ESM) 1.36 KB (+2.27% 🔺)
@apollo/client-react-streaming/manual-transport (Browser ESM) 6.45 KB (0%)
@apollo/client-react-streaming/manual-transport (SSR ESM) 6.34 KB (+0.17% 🔺)
@apollo/experimental-nextjs-app-support/ssr (Browser ESM) 8.41 KB (0%)
@apollo/experimental-nextjs-app-support/ssr (SSR ESM) 8.33 KB (+0.28% 🔺)
@apollo/experimental-nextjs-app-support/ssr (RSC ESM) 867 B (0%)
@apollo/experimental-nextjs-app-support/rsc (RSC ESM) 626 B (0%)

Copy link

relativeci bot commented Apr 4, 2024

Job #110: Bundle Size — 1.01MiB (0%).

775d110(current) vs 100952e main#108(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #110
     Baseline
Job #108
No change  Initial JS 890.58KiB 890.58KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 0.03% 21.11%
No change  Chunks 24 24
No change  Assets 45 45
No change  Modules 512 512
No change  Duplicate Modules 30 30
No change  Duplicate Code 1.29% 1.29%
No change  Packages 29 29
No change  Duplicate Packages 1 1
Bundle size by type  no changes
                 Current
Job #110
     Baseline
Job #108
Not changed  JS 1023.84KiB 1023.84KiB
Not changed  Other 5.99KiB 5.99KiB

View job #110 reportView pr/connectToDevTools branch activityView project dashboard

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet. Love it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set connectToDevTools default to false in RSC and SSR builds
2 participants