SSR support #3
Merged
SSR support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
commented
Apr 11, 2023
Comment on lines
9
to
32
| function makeClient() { | ||
| return new ApolloClient({ | ||
| cache: new NextSSRInMemoryCache(), | ||
| link: new HttpLink({ | ||
| uri: "http://localhost:3000/api/graphql", | ||
| fetchOptions: { cache: "no-store" }, | ||
| }), | ||
| }); | ||
| } | ||
|
|
||
| function makeSuspenseCache() { | ||
| return new SuspenseCache(); | ||
| } | ||
|
|
||
| export function Providers({ children }: React.PropsWithChildren) { | ||
| return ( | ||
| <ApolloProvider | ||
| makeClient={makeClient} | ||
| makeSuspenseCache={makeSuspenseCache} | ||
| > | ||
| {children} | ||
| </ApolloProvider> | ||
| ); | ||
| } |
There was a problem hiding this comment.
This shows a "typical" use in a SSR environment: We have this Provider file with "use client" that uses the (for now) "@apollo/experimental-next/dist/ssr" ApolloProvider and uses the NextSSRInMemoryCache.
Then we hook that up in the Layout and use the hooks from "@apollo/experimental-next/dist/ssr" in client components.
|
Let's get this in for now, we can iterate on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at SSR support.
It irritatingly still errors with hydration problems at the first render after app start, but everything after that is fine. Still have to look into that, something with id generation. It might also just be a next/react bug at this point, though.
Edit: that rehydration bug only occurs in NextJS dev mode on the first execution after start. (I opened an issue: vercel/next.js#48284 )