Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use \ instead of double spaces to add line breaks #310

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

jer-k
Copy link
Contributor

@jer-k jer-k commented Jun 5, 2024

https://github.com/apollographql/apollo-client-nextjs/pull/309/files#r1628079676

As noted in the other PR, GFM actually supports double spaces as line breaks (https://github.github.com/gfm/#hard-line-breaks), who knew!

This uses the other option of \ to indicate a line break so editors don't automatically clean it up and cause issues in the future

@jer-k jer-k requested a review from a team as a code owner June 5, 2024 19:50
Copy link

netlify bot commented Jun 5, 2024

👷 Deploy request for apollo-client-nextjs-docmodel pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a6ee36b

Copy link

relativeci bot commented Jun 5, 2024

#224 Bundle Size — 1.07MiB (0%).

a6ee36b(current) vs 4f4124e main#223(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Bundle metrics  no changes
                 Current
#224
     Baseline
#223
No change  Initial JS 939.02KiB 939.02KiB
No change  Initial CSS 70B 70B
No change  Cache Invalidation 0.03% 0.03%
No change  Chunks 32 32
No change  Assets 56 56
No change  Modules 591 591
No change  Duplicate Modules 110 110
No change  Duplicate Code 7.61% 7.61%
No change  Packages 26 26
No change  Duplicate Packages 1 1
Bundle size by type  no changes
                 Current
#224
     Baseline
#223
No change  JS 1.06MiB 1.06MiB
No change  Other 8.67KiB 8.67KiB
No change  CSS 70B 70B

Bundle analysis reportBranch jer-k:update-hooks-docsProject dashboard

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@jerelmiller jerelmiller merged commit 2481ea1 into apollographql:main Jun 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants