-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the hook hydration cache resilient against unmounted recreation of ManualDataTransport
#375
Conversation
…of `ManualDataTransport`
✅ Deploy Preview for apollo-client-nextjs-docmodel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
size-limit report 📦
|
#262 Bundle Size — 1.1MiB (~+0.01%).4fcd604(current) vs dd8e3a2 main#261(baseline) Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
Current #262 |
Baseline #261 |
|
---|---|---|
Initial JS | 923.9KiB (~+0.01% ) |
923.85KiB |
Initial CSS | 70B |
70B |
Cache Invalidation | 22.66% |
27.55% |
Chunks | 33 |
33 |
Assets | 57 |
57 |
Modules | 588 |
588 |
Duplicate Modules | 99 |
99 |
Duplicate Code | 6.23% |
6.23% |
Packages | 26 |
26 |
Duplicate Packages | 1 |
1 |
Bundle size by type 1 change
1 regression
Current #262 |
Baseline #261 |
|
---|---|---|
JS | 1.09MiB (~+0.01% ) |
1.09MiB |
Other | 8.78KiB |
8.78KiB |
CSS | 70B |
70B |
Bundle analysis report Branch pr/resilient-hookHydrationCache Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
This should fix the issue with an hydration error of
useQuery
that came up in #368, where no suspense boundary existed and as a result, theuseRef
ofManualDataTransport
became re-initialized.