-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run tests with next 15, bump peerDependency #379
Conversation
✅ Deploy Preview for apollo-client-nextjs-docmodel ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
size-limit report 📦
|
@phryneas thank you for this, just made a PR myself and realised you had beat me to it by 1 minute |
@The-Code-Monkey Thank you for opening that other PR! I'll probably have to tweak a few more things, so I hope it's okay if we leave things to this PR for now, okay? :) |
@phryneas yeah thats fine, hopefully this is pretty straight forwards though and not much needs changing. I use the nextjs experimental package at work so would be nice to be able to update as soon as. but not a big rush. |
Seems that at least some things in our tests need to change due to breaking Next.js changes. |
Ah yeah headers, cookies, params are now all async. that will probably be the biggest change. |
I wish it were |
Oh fun. well it was going to break some packages. strange that it went from error to undefined though |
I mean, it's only in our tests where we test that React should throw a certain error in a specific situation, so I'll shrug it off as RC weirdness, but it doesn't give me a whole lot of confidence into Next 15 so far. |
#267 Bundle Size — 1.2MiB (+8.77%).5f77ad4(current) vs 4834f55 main#265(baseline) Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
Current #267 |
Baseline #265 |
|
---|---|---|
Initial JS | 967.91KiB (+4.72% ) |
924.27KiB |
Initial CSS | 70B |
70B |
Cache Invalidation | 99.89% |
22.66% |
Chunks | 34 (+3.03% ) |
33 |
Assets | 59 (+3.51% ) |
57 |
Modules | 630 (+7.14% ) |
588 |
Duplicate Modules | 106 (+7.07% ) |
99 |
Duplicate Code | 5.33% (-14.45% ) |
6.23% |
Packages | 26 |
26 |
Duplicate Packages | 1 |
1 |
Bundle size by type 2 changes
2 regressions
Current #267 |
Baseline #265 |
|
---|---|---|
JS | 1.19MiB (+8.81% ) |
1.09MiB |
Other | 9.09KiB (+3.56% ) |
8.78KiB |
CSS | 70B |
70B |
Bundle analysis report Branch pr/next-15 Project dashboard
Generated by RelativeCI Documentation Report issue
Well, that's now all green. I'll take the win and get this released :) |
No description provided.