Make useQuery stale variables test less flaky.

apollographql · May 13, 2022 · 75662a3 · 75662a3
1 parent 74d2072
commit 75662a3
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/react/hooks/__tests__/useQuery.test.tsx b/src/react/hooks/__tests__/useQuery.test.tsx
@@ -437,11 +437,16 @@ describe('useQuery Hook', () => {
       expect(result.current[0].loading).toBe(true);
       expect(result.current[0].data).toBe(undefined);
       expect(result.current[0].variables).toEqual({ name: "world 2" });
+
       await waitForNextUpdate();
 
-      expect(result.current[0].loading).toBe(false);
-      expect(result.current[0].data).toEqual({ hello: "world 2" });
-      expect(result.current[0].variables).toEqual({ name: "world 2" });
+      // TODO(investigate) Without waitFor, loading is sometimes still true
+      // here, after awaiting waitForNextUpdate().
+      return waitFor(() => {
+        expect(result.current[0].loading).toBe(false);
+        expect(result.current[0].data).toEqual({ hello: "world 2" });
+        expect(result.current[0].variables).toEqual({ name: "world 2" });
+      });
     });
 
     // TODO: Rewrite this test