Use printed query for deduplication, cache print calls (#10968)

Co-authored-by: Jerel Miller <jerelmiller@gmail.com>

.changeset/rude-frogs-destroy.md

@@ -0,0 +1,5 @@
+---
+'@apollo/client': patch
+---
+
+Use printed query for query deduplication. Cache `print` calls for GraphQL documents to speed up repeated operations.

.prettierignore

@@ -74,6 +74,7 @@ src/utilities/globals/*
 !src/utilities/graphql
 src/utilities/graphql/*
 !src/utilities/graphql/operations.ts
+!src/utilities/graphql/print.ts
 !src/utilities/graphql/DocumentTransform.ts
 !src/utilities/graphql/__tests__/
 src/utilities/graphql/__tests__/*

.size-limit.cjs

@@ -1,7 +1,7 @@
 const checks = [
   {
     path: "dist/apollo-client.min.cjs",
-    limit: "37460"
+    limit: "37479"
   },
   {
     path: "dist/main.cjs",
@@ -10,7 +10,7 @@ const checks = [
   {
     path: "dist/index.js",
     import: "{ ApolloClient, InMemoryCache, HttpLink }",
-    limit: "33243"
+    limit: "33269"
   },
   ...[
     "ApolloProvider",

src/__tests__/__snapshots__/exports.ts.snap

@@ -455,6 +455,7 @@ Array [
   "mergeOptions",
   "offsetLimitPagination",
   "omitDeep",
+  "print",
   "relayStylePagination",
   "removeArgumentsFromDocument",
   "removeClientSetsFromDocument",

src/core/QueryManager.ts

@@ -69,6 +69,7 @@ import {
 } from './QueryInfo';
 import type { ApolloErrorOptions } from '../errors';
 import { PROTOCOL_ERRORS_SYMBOL } from '../errors';
+import { print } from '../utilities';
 
 const { hasOwnProperty } = Object.prototype;
 
@@ -1027,7 +1028,7 @@ export class QueryManager<TStore> {
   }
 
   private inFlightLinkObservables = new Map<
-    DocumentNode,
+    string,
     Map<string, Observable<FetchResult>>
   >();
 
@@ -1059,8 +1060,9 @@ export class QueryManager<TStore> {
       context = operation.context;
 
       if (deduplication) {
-        const byVariables = inFlightLinkObservables.get(serverQuery) || new Map();
-        inFlightLinkObservables.set(serverQuery, byVariables);
+        const printedServerQuery = print(serverQuery);
+        const byVariables = inFlightLinkObservables.get(printedServerQuery) || new Map();
+        inFlightLinkObservables.set(printedServerQuery, byVariables);
 
         const varJson = canonicalStringify(variables);
         observable = byVariables.get(varJson);
@@ -1075,7 +1077,7 @@ export class QueryManager<TStore> {
           concast.beforeNext(() => {
             if (byVariables.delete(varJson) &&
                 byVariables.size < 1) {
-              inFlightLinkObservables.delete(serverQuery);
+              inFlightLinkObservables.delete(printedServerQuery);
             }
           });
         }

src/link/http/selectHttpOptionsAndBody.ts

@@ -1,5 +1,5 @@
 import type { ASTNode} from 'graphql';
-import { print } from 'graphql';
+import { print } from '../../utilities';
 
 import type { Operation } from '../core';
 

src/link/persisted-queries/index.ts

@@ -1,6 +1,6 @@
 import { invariant } from '../../utilities/globals';
 
-import { print } from 'graphql';
+import { print } from '../../utilities';
 import type {
   DocumentNode,
   ExecutionResult,

src/link/subscriptions/index.ts

@@ -28,7 +28,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
-import { print } from "graphql";
+import { print } from '../../utilities';
 import type { Client } from "graphql-ws";
 
 import type { Operation, FetchResult } from "../core";

src/testing/core/mocking/mockLink.ts

@@ -1,6 +1,5 @@
 import { invariant } from '../../../utilities/globals';
 
-import { print } from 'graphql';
 import { equal } from '@wry/equality';
 
 import type {
@@ -18,6 +17,7 @@ import {
   removeConnectionDirectiveFromDocument,
   cloneDeep,
   stringifyForDisplay,
+  print
 } from '../../../utilities';
 
 export type ResultFunction<T> = () => T;

src/testing/matchers/toMatchDocument.ts

@@ -1,5 +1,4 @@
-import { checkDocument } from '../../utilities';
-import { print } from 'graphql';
+import { checkDocument, print } from '../../utilities';
 import type { DocumentNode } from '../../core';
 import type { MatcherFunction } from 'expect';
 

src/utilities/graphql/print.ts

@@ -0,0 +1,14 @@
+import { print as origPrint } from 'graphql';
+import { canUseWeakMap } from '../common/canUse';
+
+const printCache = canUseWeakMap ? new WeakMap() : undefined;
+export const print: typeof origPrint = (ast) => {
+  let result;
+  result = printCache?.get(ast);
+
+  if (!result) {
+    result = origPrint(ast);
+    printCache?.set(ast, result);
+  }
+  return result;
+};

src/utilities/index.ts

@@ -36,6 +36,10 @@ export {
   getDefaultValues,
 } from './graphql/getFromAST';
 
+export {
+  print
+} from './graphql/print';
+
 export {
   StoreObject,
   Reference,