Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update peer dependency for latest graphql release #3562

Closed
NathanielHill opened this issue Jun 8, 2018 · 0 comments · Fixed by #3598
Closed

Update peer dependency for latest graphql release #3562

NathanielHill opened this issue Jun 8, 2018 · 0 comments · Fixed by #3598
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. ✔ confirmed 🙏 help-wanted

Comments

@NathanielHill
Copy link

warning " > apollo-client@2.3.2" has incorrect peer dependency "graphql@^0.11.0 || ^0.12.0 || ^0.13.0".

Release candidates are in the npm registry for graphql@v14.0.0, can the peer dependencies be updated?
@hwillson hwillson added 🙏 help-wanted feature 📚 good-first-issue Issues that are suitable for first-time contributors. ✔ confirmed labels Jun 14, 2018
ivank added a commit to ivank/apollo-client that referenced this issue Jun 19, 2018
@ivank
Bump graphql version to 14.0.0
aeeb6d3 
So graphql are transitioning to real semver finally. This should fix apollographql#3562

I've set the devDependency to graphql@14.0.0-rc.2 to be able to be able
to run the tests on the new version and make sure everything's fine. But
I'm not sure if you think its ok to merge with that release candidate.

Also I think the semver in peerDependencies is more verbose than it
should be:

```js
"peerDependencies": {
    "graphql": "^0.11.0 || ^14.0.0"
}
```
This should cover all of the graphql versions from 0.11 and up, since
["^" includes minor and patch
versions](https://bytearcher.com/articles/semver-explained-why-theres-a-caret-in-my-package-json/)
@ivank ivank mentioned this issue Jun 19, 2018
Merged
3 tasks
@mikl mikl mentioned this issue Jul 25, 2018
Closed
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
📚 good-first-issue Issues that are suitable for first-time contributors. ✔ confirmed 🙏 help-wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump graphql version to 14.0.0 ivank/apollo-client
2 participants
@hwillson @NathanielHill