Mutation will throw a missing store field if a query before errored or was canceled

[rricard]

This following line will throw: https://github.com/apollostack/apollo-client/blob/master/src/data/diffAgainstStore.ts#L339 on a mutation if a query before was canceled or errored. This is bad since it makes fail every mutation even the unrelated ones! I had hard time pinpointing this one but we should find an elegant solution to it. For now I'll try to set globally throwOnMissingField to false but I think we have ways to be smarter (preventing to register a failed or canceled result is one of those)

The stack I got is here:

Can't find field searchNodes({"query":"TEST","limit":40,"cursor":null}) on object ($ROOT_QUERY.connection({"id":"xxx"})) {
  "service": {
    "type": "id",
    "id": "$ROOT_QUERY.connection({\"id\":\"xxx\"}).service",
    "generated": true
  },
  "disconnected": false,
  "pins": [
    "$ROOT_QUERY.connection({\"id\":\"xxx\"}).pins.0",
    "$ROOT_QUERY.connection({\"id\":\"xxx\"}).pins.1",
    "$ROOT_QUERY.connection({\"id\":\"xxx\"}).pins.2",
    "$ROOT_QUERY.connection({\"id\":\"xxx\"}).pins.3"
  ],
  "user": {
    "type": "id",
    "id": "$ROOT_QUERY.connection({\"id\":\"xxx\"}).user",
    "generated": true
  },
  "id": "xxx",
  "handle": "xxx",
  "node({\"id\":\"root\"})": {
    "type": "id",
    "id": "$ROOT_QUERY.connection({\"id\":\"xxx\"}).node({\"id\":\"root\"})",
    "generated": true
  },
  "nodeChildren({\"id\":\"root\",\"limit\":40,\"cursor\":null,\"sortBy\":null})": {
    "type": "id",
    "id": "$ROOT_QUERY.connection({\"id\":\"xxx\"}).nodeChildren({\"id\":\"root\",\"limit\":40,\"cursor\":null,\"sortBy\":null})",
    "generated": true
  }
}.
Perhaps you want to use the `returnPartialData` option?"

Error
    at new ApolloError (webpack:///./~/apollo-client/errors.js?:14:22)
    at diffFieldAgainstStore (webpack:///./~/apollo-client/data/diffAgainstStore.js?:201:19)
    at eval (webpack:///./~/apollo-client/data/diffAgainstStore.js?:73:30)
    at Array.forEach (native)
    at diffSelectionSetAgainstStore (webpack:///./~/apollo-client/data/diffAgainstStore.js?:61:29)
    at diffFieldAgainstStore (webpack:///./~/apollo-client/data/diffAgainstStore.js?:256:16)
    at eval (webpack:///./~/apollo-client/data/diffAgainstStore.js?:73:30)
    at Array.forEach (native)
    at Object.diffSelectionSetAgainstStore (webpack:///./~/apollo-client/data/diffAgainstStore.js?:61:29)
    at Object.readSelectionSetFromStore (webpack:///./~/apollo-client/data/readFromStore.js?:31:37)

[rricard]

Well! Got the source of the bug: when the mutation applies an updateQueries, a read in the store gets triggered and at this point, no returnPartialData is set. Now the question is what to do to fix it?

• Proposition 1: we should find a way to have updateQueries ignore errored/cancelled queries
• Proposition 2: execute updateQueries's store read using returnPartialData. This one can have nasty side effects in the implemented updateQueries reducers...

[rricard]

I reproduced the bug in a test in #651