Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various flaky tests before publishing @apollo/client@v3.7.0-rc.0 #10118

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Fix various flaky tests before publishing @apollo/client@v3.7.0-rc.0 #10118

merged 2 commits into from
Sep 21, 2022

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Sep 21, 2022

No description provided.

@benjamn benjamn added this to the Release 3.7 milestone Sep 21, 2022
@benjamn benjamn self-assigned this Sep 21, 2022
@benjamn benjamn merged commit c253bb3 into release-3.7 Sep 21, 2022
@benjamn benjamn deleted the fix-various-flaky-tests-before-v3.7-RC0 branch September 21, 2022 22:54
benjamn added a commit that referenced this pull request Oct 19, 2022
@benjamn
Attempt to fix flaky useFragment test by removing Promise.
d342651 
This useFragment test has been failing locally for me and has even
failed on main for otherwise innocuous commits like
2db905f.

I added this Promise logic in #10118 to fix another flakiness issue, but
the current state seems worse (more frequent failures) than before.
@benjamn benjamn mentioned this pull request Oct 19, 2022
Merged
benjamn added a commit that referenced this pull request Oct 19, 2022
@benjamn
Add back 10ms delay before first checking getItemTexts().
2b12820 
If there was anything about the Promise approach (#10118) that was
helpful, it was probably the extra await before the waitFor checking
getItemTexts, so this commit reintroduces that brief pause.
benjamn added a commit that referenced this pull request Oct 19, 2022
@benjamn
Attempt to fix flaky useFragment test by removing Promise.
cb70daa 
This useFragment test has been failing locally for me and has even
failed on main for otherwise innocuous commits like
2db905f.

I added this Promise logic in #10118 to fix another flakiness issue, but
the current state seems worse (more frequent failures) than before.
benjamn added a commit that referenced this pull request Oct 20, 2022
@benjamn
Attempt to fix flaky useFragment test by removing Promise.
855f171 
This useFragment test has been failing locally for me and has even
failed on main for otherwise innocuous commits like
2db905f.

I added this Promise logic in #10118 to fix another flakiness issue, but
the current state seems worse (more frequent failures) than before.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@benjamn benjamn

Labels
None yet
Projects
None yet
Milestone
Release 3.7
Development

Successfully merging this pull request may close these issues.
1 participant
@benjamn