Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stopped queries from store and internal tracking #1054

Merged
merged 12 commits into from
Dec 17, 2016
Merged

Conversation

helfer
Copy link
Contributor

@helfer helfer commented Dec 17, 2016

Fixes #902 #903 (?) #993 #1026

This was a pretty hairy affair, but I think I've managed to untangle things enough so that stopped queries are now actually removed from the store and no longer tracked. That means that their reducers and updateQuery functions no longer run.

I don't think #903 is really fixed by this, but the discussion there is so long that I think it's better if we start a new issue about running reducers for other variables than the current query variables (cc @richburdon @yurigenin)

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@helfer helfer merged commit 4a6e1ea into master Dec 17, 2016
@helfer helfer changed the title Fix reducers Remove stopped queries from store and internal tracking Dec 17, 2016
@helfer helfer deleted the fix-reducers branch December 17, 2016 15:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about stopped queries and potential bug
1 participant