Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Multipart Subscriptions #10592

Merged
merged 33 commits into from
Mar 30, 2023
Merged

feat: Multipart Subscriptions #10592

merged 33 commits into from
Mar 30, 2023

Conversation

alessbell
Copy link
Member

@alessbell alessbell commented Feb 22, 2023 •
edited
Loading

Adds support for multipart subscriptions by passing the appropriate headers in the terminating HTTPLink if it receives subscription operations.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 97e4e60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 22, 2023

✅ Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 774102c
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/63f6469fe9e894000766d406
😎 Deploy Preview https://deploy-preview-10592--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alessbell
Copy link
Member Author

/release:pr

@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit ca2d678
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6424a7a9dfedc90008136ac9
😎 Deploy Preview https://deploy-preview-10592--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10592-20230222165542.

alessbell
alessbell commented Mar 22, 2023
View reviewed changes
src/link/core/types.ts Outdated Show resolved Hide resolved
@alessbell
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10592-20230328153218.

benjamn
benjamn reviewed Mar 28, 2023
View reviewed changes
src/core/QueryManager.ts Outdated Show resolved Hide resolved
src/link/http/parseAndCheckHttpResponse.ts Outdated Show resolved Hide resolved
src/link/core/types.ts Outdated Show resolved Hide resolved
jerelmiller
jerelmiller approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few minor suggestions that you can take or leave, but otherwise looks great! Excited to get this out there!

src/__tests__/graphqlSubscriptions.ts Outdated Show resolved Hide resolved
src/__tests__/graphqlSubscriptions.ts Outdated Show resolved Hide resolved
src/link/http/createHttpLink.ts Outdated Show resolved Hide resolved
src/react/hooks/__tests__/useSubscription.test.tsx Outdated Show resolved Hide resolved
benjamn
benjamn reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last suggestions. Thanks for pushing this forward @alessbell!

src/errors/index.ts Outdated Show resolved Hide resolved
src/link/http/parseAndCheckHttpResponse.ts Outdated Show resolved Hide resolved
src/core/QueryManager.ts Outdated Show resolved Hide resolved
src/utilities/common/incrementalResult.ts Outdated Show resolved Hide resolved
benjamn
benjamn approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@benjamn benjamn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge away! Maybe squash (up to you)? One small non-blocking simplification (see comment below).

src/utilities/common/incrementalResult.ts Outdated Show resolved Hide resolved
@alessbell @benjamn
Update src/utilities/common/incrementalResult.ts
97e4e60 
Co-authored-by: Ben Newman <ben@apollographql.com>
@alessbell alessbell merged commit cdb98ae into main Mar 30, 2023
@alessbell alessbell deleted the router-subs branch March 30, 2023 16:57
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Merged
lovasoa pushed a commit to lovasoa/apollo-client that referenced this pull request Mar 30, 2023
@alessbell @lovasoa
feat: Multipart Subscriptions (apollographql#10592)
2560e67
@benjamn benjamn mentioned this pull request Mar 31, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

@benjamn benjamn benjamn approved these changes

@phryneas phryneas Awaiting requested review from phryneas

Assignees

@alessbell alessbell

Labels
🥚 backwards-compatible for PRs that do not introduce any breaking changes 🧞‍♂️ enhancement 🛎 subscriptions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessbell @benjamn @jerelmiller