Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSuspenseCache: add suspenseCache option #10594

Merged
merged 4 commits into from
Feb 23, 2023
Merged

useSuspenseCache: add suspenseCache option #10594

merged 4 commits into from
Feb 23, 2023

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Feb 23, 2023 •
edited
Loading

closes #10503

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@phryneas phryneas requested a review from jerelmiller February 23, 2023 11:00
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 6c19e8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10594-20230223111013.

@phryneas
Copy link
Member Author

@patrick91 wanna give this a try? :)

@patrick91
Copy link

@phryneas worked like a charm! thank you!

jerelmiller
jerelmiller reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 Thanks for being so thorough! I had some minor suggestions on wording, but this PR looks awesome. Thanks for getting this in there!

.changeset/curvy-dragons-talk.md Outdated Show resolved Hide resolved
src/react/hooks/__tests__/useSuspenseQuery.test.tsx Outdated Show resolved Hide resolved
@jerelmiller jerelmiller linked an issue Feb 23, 2023 that may be closed by this pull request
Allow to use useSuspenseQuery without wrapping it in ApolloProvider #10503
Closed
@phryneas @jerelmiller
Apply suggestions from code review
6c19e8a 
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
@phryneas
Copy link
Member Author

Thanks for the nitpicks, I suck at wording 😁

@phryneas phryneas merged commit f221b5e into release-3.8 Feb 23, 2023
@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Merged
@jerelmiller jerelmiller deleted the pr/10503 branch February 23, 2023 22:43
@jerelmiller jerelmiller mentioned this pull request Mar 13, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jerelmiller jerelmiller jerelmiller approved these changes

Assignees

@phryneas phryneas

Labels
⏲️ react-suspense
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to use useSuspenseQuery without wrapping it in ApolloProvider
3 participants
@phryneas @patrick91 @jerelmiller