Upgrade to TypeScript 5.0 #10660
Merged
Upgrade to TypeScript 5.0 #10660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d41488 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
/release:pr |
|
🤯 🤯 🤯 That was fast |
|
A new release has been made for this PR. You can install it with |
alessbell
added
the
🥚 backwards-compatible
|
I've used a bundle analyzer to compare before/after and diffed individual files. This change is backward-compatible and safe to ship at a patch version 🙌 Before/after comparison of compiled
|
alessbell
force-pushed
the
typescript-5.0
branch
from
2d38dd2 to
7d41488
Compare
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades to the newly-released TypeScript v5.0.
We anticipated this upgrade to be painless after making the necessary changes to adopt
v4.9.4in #10470. So far this seems to be true 🎉npx tsc --noEmitsucceeds. Additionally I'll be running our E2E tests with a snapshot release of this branch (apollographql/client-router-e2e-tests#75) and comparing the compiled output to determine whether this can be shipped at a patch or should target ourrelease-3.8branch. (Edit: we're clear to proceed at a patch version bump!)