Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApolloProvider: ensure context value stability #10869

Merged
merged 6 commits into from
May 16, 2023
Merged

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented May 15, 2023

This fixes #7626

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@phryneas phryneas self-assigned this May 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: 247419b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas phryneas changed the title Pr/fix 7626 @phryneas ApolloProvider: ensure context value stability May 15, 2023
@phryneas phryneas marked this pull request as ready for review May 15, 2023 09:12
@phryneas phryneas changed the title @phryneas ApolloProvider: ensure context value stability polloProvider: ensure context value stability May 15, 2023
@phryneas phryneas changed the title polloProvider: ensure context value stability ApolloProvider: ensure context value stability May 15, 2023
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple minor suggestions that I think could simplify this a tad more. Feel free to take it or leave it. Thanks for getting this updated!

src/react/context/ApolloProvider.tsx Outdated Show resolved Hide resolved
src/react/context/ApolloProvider.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 35.8 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 45.26 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.05 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 871 B (+0.47% 🔺)
import { useQuery } from "dist/react/index.js" 4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.66 KB (0%)
import { useMutation } from "dist/react/index.js" 2.52 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.36 KB (0%)
import { useSuspenseQuery_experimental } from "dist/react/index.js" 3.53 KB (0%)
import { useBackgroundQuery_experimental } from "dist/react/index.js" 2.97 KB (0%)
import { useReadQuery_experimental } from "dist/react/index.js" 1.12 KB (0%)
import { useFragment_experimental } from "dist/react/index.js" 1.78 KB (0%)

phryneas and others added 2 commits May 16, 2023 10:22
Co-authored-by: Jerel Miller <jerelmiller@gmail.com>
@phryneas phryneas merged commit ba1d061 into release-3.8 May 16, 2023
@phryneas phryneas deleted the pr/fix-7626 branch May 16, 2023 08:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants