Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useGETForQueries option in BatchHttpLink.Options #10962

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

jerelmiller
Copy link
Member

Fixes #10956

The useGETForQueries option is not supported in BatchHttpLink, but our TypeScript type currently allows this option. This PR removes support for that option in the TypeScript type to ensure devs trying to use this option are properly warned that the option is not supported.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2023

🦋 Changeset detected

Latest commit: 03efb89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 33.66 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 42.39 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.47 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 917 B (0%)
import { useQuery } from "dist/react/index.js" 24.96 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 25.26 KB (0%)
import { useMutation } from "dist/react/index.js" 23.5 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.43 KB (0%)
import { useFragment_experimental } from "dist/react/index.js" 1.84 KB (0%)

Copy link
Member

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have this updated 🎉

@jerelmiller jerelmiller merged commit 772cfa3 into main Jun 9, 2023
@jerelmiller jerelmiller deleted the remove-get-batch-option branch June 9, 2023 18:50
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useGETForQueries is accepted but doesn't work with BatchHttpLink
2 participants