-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: variables incorrectly removed in BatchHttpLink
#10964
Conversation
🦋 Changeset detectedLatest commit: a7f3007 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
@@ -352,6 +352,62 @@ describe('SharedHttpTest', () => { | |||
); | |||
}); | |||
|
|||
itAsync('strips unused variables, respecting nested fragments', (resolve, reject) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test need to call resolve
anywhere to get it to complete correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the tests pass, so that answers my question 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's called in makeCallback
, but yeah a bit hard to see :D
Fixes a bug in #10754 which caused all variables to be removed from
BatchHttpLink
requests. Added the same integration test used inHttpLink
's test suite.Checklist: