Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: variables incorrectly removed in BatchHttpLink #10964

Merged
merged 5 commits into from
Jun 9, 2023

Conversation

alessbell
Copy link
Contributor

@alessbell alessbell commented Jun 9, 2023

Fixes a bug in #10754 which caused all variables to be removed from BatchHttpLink requests. Added the same integration test used in HttpLink's test suite.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

🦋 Changeset detected

Latest commit: a7f3007

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alessbell alessbell requested review from jerelmiller and phryneas June 9, 2023 17:55
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 36.55 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 42.95 KB (-0.01% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.43 KB (-0.01% 🔽)
import { ApolloProvider } from "dist/react/index.js" 1.3 KB (0%)
import { useQuery } from "dist/react/index.js" 4.34 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.66 KB (0%)
import { useMutation } from "dist/react/index.js" 2.57 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.34 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 3.45 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 2.89 KB (0%)
import { useReadQuery } from "dist/react/index.js" 1.65 KB (0%)
import { useFragment } from "dist/react/index.js" 2.12 KB (0%)

@alessbell alessbell self-assigned this Jun 9, 2023
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@@ -352,6 +352,62 @@ describe('SharedHttpTest', () => {
);
});

itAsync('strips unused variables, respecting nested fragments', (resolve, reject) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this test need to call resolve anywhere to get it to complete correctly?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the tests pass, so that answers my question 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's called in makeCallback, but yeah a bit hard to see :D

@alessbell alessbell merged commit f331715 into release-3.8 Jun 9, 2023
@alessbell alessbell deleted the batch-http-link-variables-fix branch June 9, 2023 19:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants