Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspense cache: use Trie directly #10969

Merged
merged 9 commits into from
Jun 13, 2023

Conversation

phryneas
Copy link
Member

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

I saw this and thought we could save some bundle size here by using Trie directly - with the downside that this is a bit harder to test.
@jerelmiller what are your thoughts on this? If you think this makes sense, I'll try to find a way to rewrite those failing tests.

@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

🦋 Changeset detected

Latest commit: f75529d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas phryneas changed the title Pr/suspense cache use trie directly Suspense cache: use Trie directly Jun 12, 2023
@phryneas phryneas requested a review from jerelmiller June 12, 2023 10:26
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 36.52 KB (-0.09% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 42.93 KB (-0.05% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.43 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.3 KB (0%)
import { useQuery } from "dist/react/index.js" 4.34 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.66 KB (0%)
import { useMutation } from "dist/react/index.js" 2.57 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.34 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 3.45 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 2.89 KB (0%)
import { useReadQuery } from "dist/react/index.js" 1.65 KB (0%)
import { useFragment } from "dist/react/index.js" 2.12 KB (0%)

@phryneas phryneas self-assigned this Jun 12, 2023
@jerelmiller jerelmiller marked this pull request as ready for review June 13, 2023 19:49
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! Thanks for recognizing this optimization! 🔥

@jerelmiller jerelmiller merged commit 525a931 into release-3.8 Jun 13, 2023
@jerelmiller jerelmiller deleted the pr/SuspenseCache-use-Trie-directly branch June 13, 2023 21:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants