Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Prettier #11111

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Apply Prettier #11111

merged 12 commits into from
Aug 1, 2023

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Jul 28, 2023

This PR "inverses" our .prettierignore file, upgrades prettier to v3, moves the .prettierrc out of the package.json, applies the change to ' vs " that we decided upon and then formats the following folders:

  • config - I hope this one is okay even if we didn't talk about that, the files in there are just really hard to handle without proper formatting
  • integration-tests (should have been formatted all along)
  • src/react folders.
  • a bunch of config files that were previously unformatted

Probably relevant for review: diff on the output files

I'll add the resulting commit after we squash merge to https://github.com/apollographql/apollo-client/blob/main/.git-blame-ignore-revs - adding anything now wouldn't have any impact.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

⚠️ No Changeset found

Latest commit: 9d68325

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.16 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 43.73 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 42.33 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.39 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.22 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.21 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.2 KB (0%)
import { useQuery } from "dist/react/index.js" 4.29 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.1 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 4.6 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.42 KB (0%)
import { useMutation } from "dist/react/index.js" 2.53 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.51 KB (0%)
import { useSubscription } from "dist/react/index.js" 2.24 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.2 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 4.71 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.14 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.2 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 2.69 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.67 KB (0%)
import { useFragment } from "dist/react/index.js" 2.08 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.03 KB (0%)

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 11a5b1b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/64c3e860aadc3f000833fe9c
😎 Deploy Preview https://deploy-preview-11111--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas phryneas marked this pull request as ready for review July 31, 2023 12:40
Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@alessbell alessbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@phryneas phryneas merged commit ba3e7d9 into release-3.8 Aug 1, 2023
@jerelmiller jerelmiller deleted the pr/prettier branch August 4, 2023 17:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants