-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tag latest prerelease with next npm tag after initial release #11226
chore: tag latest prerelease with next npm tag after initial release #11226
Conversation
…npm tag on publish
|
size-limit report 📦
|
@@ -65,17 +65,6 @@ jobs: | |||
env: | |||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
|
|||
- name: Get package version from package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're using the changeset GitHub Action in our prerelease workflow we don't need to do additional work to read the package version
payload: | | ||
{ | ||
"blocks": [ | ||
{ | ||
"type": "section", | ||
"text": { | ||
"type": "mrkdwn", | ||
"text": "A new version of `@apollo/client` was released :rocket:" | ||
"text": "A new version of `@apollo/client` was released: <https://github.com/apollographql/apollo-client/releases/tag/v${{ fromJson(steps.changesets.outputs.publishedPackages)[0].version }}|v${{ fromJson(steps.changesets.outputs.publishedPackages)[0].version }}> :rocket:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the message more concise here for prereleases :)
Changesets does not allow prerelease versions to be released at an npm tag other than the semantic tag specfied in
pre.json
(open issue).Instead, we'll publish the release with e.g. tag
alpha
and then immediately use dist-tag to tag that release withnext
.