Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markMutationResult not to run refetchQueries when fetchPolicy === 'no-cache'… #11240

Conversation

msand
Copy link

@msand msand commented Sep 22, 2023

… and mutation.refetchQueries is empty array (default argument)

@netlify
Copy link

netlify bot commented Sep 22, 2023

‼️ Deploy request for apollo-client-docs rejected.

Name Link
🔨 Latest commit 3a84514

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

⚠️ No Changeset found

Latest commit: bd628f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@msand msand force-pushed the fix-refetchQueries-when-fetchPolicy-is-no-cache branch 3 times, most recently from 2725935 to 17ddc0e Compare September 22, 2023 12:46
… 'no-cache' and mutation.refetchQueries is empty array (default argument)
@msand msand force-pushed the fix-refetchQueries-when-fetchPolicy-is-no-cache branch from 17ddc0e to bd628f6 Compare September 22, 2023 12:51
@msand
Copy link
Author

msand commented Sep 25, 2023

@benjamn Good day sir! This change took an edge case of ours from taking about an hour to about one minute instead. Do you see any issues with this change?

@jerelmiller
Copy link
Member

Hey @msand 👋

We just merged #11515 which I just noticed fixes the same issue. Apologies we didn't see this first! Since this issue will be fixed with 3.9.1 via #11515, I'm going to go ahead and close this. Thanks for the contribution regardless!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants