Implement basic network error handling #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stubailo
changed the title
|
@stubailo so this removes the |
|
Currently, it shims But it might be kind of pointless to have that, since |
|
@stubailo: Yeah, the shim was just to not to have to change the tests while I was working on it. Definitely should be removed. |
|
OK, going to do that now! |
|
Filed a docs issue: https://github.com/apollostack/docs/issues/12 |
|
OK, looks like error handling works, we can implement the observable API on top of this. |
This was referenced Jul 31, 2017
jbaxleyiii
pushed a commit
that referenced
this pull request
Oct 17, 2017
* Recommended that gql literals be imported in all files. * Fixed error and switched to new graphql-tag package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from @martijnwalraven's PR #97
Fixes #78