-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow undefined
as return value from cache.modify
modifier function
#11911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0a559d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Got a verbal approval from Ben on allowing this so I'm going to go ahead and merge it 🙂 |
jerelmiller
force-pushed
the
jerel/adjust-cache-modify-return-type
branch
from
June 27, 2024 18:53
81eb72e
to
0a559d1
Compare
Merged
This was referenced Jul 20, 2024
This was referenced Jul 22, 2024
This was referenced Jul 24, 2024
This was referenced Jul 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.7.x allowed
undefined
as a valid return value when usingcache.modify
. When doing so, this essentially caused the query to be refetched since the field data was removed. 3.8.x added some more robust types forcache.modify
with #10895, but as a result, we lost the ability to returnundefined
from these functions. Since the behavior is identical in > 3.8.x we should still allow this as a valid value since the client handles this correctly.