Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscribeToMore function to useBackgroundQuery, useQueryRefHandlers, and useLoadableQuery #11923

Merged
merged 9 commits into from
Jul 5, 2024

Conversation

jerelmiller
Copy link
Member

@jerelmiller jerelmiller commented Jul 3, 2024

Closes #11818

Adds support for subscribeToMore in useBackgroundQuery, useLoadableQuery, and useQueryRefHandlers that was previously missing. This was available in useSuspenseQuery but not in the other three hooks.

@jerelmiller jerelmiller added this to the 3.11.0 milestone Jul 3, 2024
Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 0688353

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jerelmiller jerelmiller requested review from phryneas and alessbell July 3, 2024 21:12
Copy link
Contributor

github-actions bot commented Jul 3, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.94 KB (+0.13% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 47.66 KB (+0.07% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 45.2 KB (+0.07% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.23 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.09 KB (+0.05% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.26 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.24 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (+0.02% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.28 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.68 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.75 KB (0%)
import { useMutation } from "dist/react/index.js" 3.59 KB (-0.03% 🔽)
import { useMutation } from "dist/react/index.js" (production) 2.81 KB (-0.04% 🔽)
import { useSubscription } from "dist/react/index.js" 3.63 KB (-0.03% 🔽)
import { useSubscription } from "dist/react/index.js" (production) 2.78 KB (-0.04% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" 5.46 KB (-0.08% 🔽)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.12 KB (-0.12% 🔽)
import { useBackgroundQuery } from "dist/react/index.js" 4.99 KB (+0.22% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.64 KB (+0.27% 🔺)
import { useLoadableQuery } from "dist/react/index.js" 5.07 KB (+0.51% 🔺)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.72 KB (+0.77% 🔺)
import { useReadQuery } from "dist/react/index.js" 3.35 KB (-0.03% 🔽)
import { useReadQuery } from "dist/react/index.js" (production) 3.3 KB (0%)
import { useFragment } from "dist/react/index.js" 2.32 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.27 KB (0%)

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 4b375bf
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6685bea5bf652000087440e5
😎 Deploy Preview https://deploy-preview-11923--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 0688353
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/66881cf4d32c2e00088b8244
😎 Deploy Preview https://deploy-preview-11923--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

return { refetch, fetchMore };
const subscribeToMore: SubscribeToMoreFunction<TData, TVariables> =
React.useCallback(
(options) => internalQueryRef.observable.subscribeToMore(options),
Copy link
Member

@phryneas phryneas Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this in soooo many places now... Suggestion: don't we just want to do bind(this) calls in the ObservableQuery constructor and remove these blocks from what feels like a hundred places?

Copy link
Member Author

@jerelmiller jerelmiller Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! This is much better 🙂 141a0e1

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@jerelmiller jerelmiller force-pushed the jerel/subscribe-to-more branch from 30ceea5 to 141a0e1 Compare July 5, 2024 15:26
@jerelmiller jerelmiller changed the title Add subscribeToMore function to useBackgroundQuery and useQueryRefHandlers Add subscribeToMore function to useBackgroundQuery, useQueryRefHandlers, and useLoadableQuery Jul 5, 2024
@phryneas phryneas added the auto-cleanup 🤖 label Jul 5, 2024
@jerelmiller jerelmiller merged commit d88c7f8 into release-3.11 Jul 5, 2024
42 checks passed
@jerelmiller jerelmiller deleted the jerel/subscribe-to-more branch July 5, 2024 16:27
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants