-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add React 19 RC to peerDependencies
#11951
Conversation
🦋 Changeset detectedLatest commit: cf2ea63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Explanation for that here: npm/node-semver#729 (comment) |
This adds the React 19 Release Candidates as valid peer dependencies.
This will allow usage with React 19 RCs - it's a bit of an optimistic assumption since RCs can still break things, but we test our code against the RCs, and we don't make any guarantees for the final React 19 release, so it should be fine and it sends a good signal that we intend to support React 19 as soon as possible.
While I'm at it, I also bump the version of the RC we run our tests with.
Important
This version range seems to break https://semver.npmjs.com/, where
"^16.8.0 || ^17.0.0 || >=19.0.0-rc <19.0.0"
works, but"^16.8.0 || ^17.0.0 || ^18.0.0 || >=19.0.0-rc <19.0.0"
doesn't.I did validate it with the
semver
package, which is supposedly used bynpm
though, and it seems to work out correctly:prints