-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect non-null assertion. #12089
Conversation
|
✅ Docs Preview ReadyNo new or changed pages found. |
commit: |
size-limit report 📦
|
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Should we have a changeset associated with this? |
This is purely an internal change - inconsequential for end users, so I'd say this doesn't need a changeset. |
@jerelmiller quoting my initial post :)
|
Gah if only I'd read a little closer 🤦🏻♂️. Thanks! |
This was erroring out in a upcoming TypeScript PR at microsoft/TypeScript#60068 (comment) - the non-null-assertion here is unnecessary and incorrect.
Thank you @Andarist for bringing it up.
No changeset since this doesn't touch runtime code or external types.