Code

Refactor accessor warnings#12143

Code

Closed

jerelmiller wants to merge 20 commits intorelease-3.12apollographql/apollo-client:release-3.12from jerel/refactor-accessor-warningsapollographql/apollo-client:jerel/refactor-accessor-warningsCopy head branch name to clipboard

+587-564

Commits

Commits on Nov 18, 2024

• Use Object.assign when handling inline fragments

  jerelmiller

  committed
  220ad82

• Move iteration into main maskSelectionSet

  jerelmiller

  committed
  35374db

• Remove fragment sorting

  jerelmiller

  committed
  d8ed107

• Better handle change tracking when returning fragment spread

  jerelmiller

  committed
  8198a8f

• Remove unused code for accessor warnings

  jerelmiller

  committed
  1d2b3e4

• Remove .failing on test

  jerelmiller

  committed
  1633ec4

• Reenable all tests

  jerelmiller

  committed
  9240062

• Remove unused import

  jerelmiller

  committed
  eec8ccc

• Use assignWithAccessors instead

  jerelmiller

  committed
  68ff5f0

• Simplify assignWithAccessors

  jerelmiller

  committed
  f0d5c56

• Fix incorrect test

  jerelmiller

  committed
  96a4977

• Move assignment of value to end of logic

  jerelmiller

  committed
  5dfeb94

Commits on Nov 19, 2024

• Ensure console mocks are cleared between checks

  jerelmiller

  committed
  0496108

• Ensure other properties are assigned with assignWithAccessors

  jerelmiller

  committed
  5f546b5

• Minor refactor on descriptor

  jerelmiller

  committed
  a7be4fb

• Set initialValue in iteration and return early when adding warning

  jerelmiller

  committed
  247cc75

• Tweak test to check which fields warned

  jerelmiller

  committed
  ad2f3f3

• Add additional check for fields

  jerelmiller

  committed
  80b8233

• Ensure value is set when assigning

  jerelmiller

  committed
  a40589a

• add additional test

  phryneas

  committed
  9ccb9ee