Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscribeAndCount testing utility #12223

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Remove subscribeAndCount testing utility #12223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81a39e3
Remove subscribeAndCount from testing utilities
jerelmiller Dec 13, 2024
d75881f
Add changeset
jerelmiller Dec 13, 2024
d1fef31
Merge branch 'release-4.0' into jerel/deprecate-subscribe-and-count
phryneas Dec 16, 2024
1c1bafb
Clean up Prettier, Size-limit, and Api-Extractor
phryneas Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .api-reports/api-report-testing.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,9 +1814,6 @@ Item
// @public (undocumented)
type StoreValue = number | string | string[] | Reference | Reference[] | null | undefined | void | Object;

// @public (undocumented)
export function subscribeAndCount<TResult>(reject: (reason: any) => any, observable: Observable<TResult>, cb: (handleCount: number, result: TResult) => any): Subscription;

// @public (undocumented)
type SubscribeToMoreOptions<TData = any, TSubscriptionVariables = OperationVariables, TSubscriptionData = TData> = {
document: DocumentNode | TypedDocumentNode<TSubscriptionData, TSubscriptionVariables>;
Expand Down
3 changes: 0 additions & 3 deletions .api-reports/api-report-testing_core.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,9 +1771,6 @@ Item
// @public (undocumented)
type StoreValue = number | string | string[] | Reference | Reference[] | null | undefined | void | Object;

// @public (undocumented)
export function subscribeAndCount<TResult>(reject: (reason: any) => any, observable: Observable<TResult>, cb: (handleCount: number, result: TResult) => any): Subscription;

// @public (undocumented)
type SubscribeToMoreOptions<TData = any, TSubscriptionVariables = OperationVariables, TSubscriptionData = TData> = {
document: DocumentNode | TypedDocumentNode<TSubscriptionData, TSubscriptionVariables>;
Expand Down
5 changes: 5 additions & 0 deletions .changeset/shiny-carrots-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@apollo/client": major
---

Remove `subscribeAndCount` testing utility from `@apollo/client/testing`.
2 changes: 0 additions & 2 deletions src/__tests__/__snapshots__/exports.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,6 @@ Array [
"itAsync",
"mockObservableLink",
"mockSingleLink",
"subscribeAndCount",
"tick",
"wait",
"withErrorSpy",
Expand All @@ -380,7 +379,6 @@ Array [
"itAsync",
"mockObservableLink",
"mockSingleLink",
"subscribeAndCount",
"tick",
"wait",
"withErrorSpy",
Expand Down
1 change: 0 additions & 1 deletion src/testing/core/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export {
mockObservableLink,
} from "./mocking/mockSubscriptionLink.js";
export { createMockClient } from "./mocking/mockClient.js";
export { default as subscribeAndCount } from "./subscribeAndCount.js";
export { itAsync } from "./itAsync.js";
export { wait, tick } from "./wait.js";
export * from "./withConsoleSpy.js";
32 changes: 0 additions & 32 deletions src/testing/core/subscribeAndCount.ts
View file
Open in desktop

This file was deleted.