Don't compare against cache if forceFetch is true #1264
Conversation
|
@stevewillard: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
src/core/QueryManager.ts
Outdated
| @@ -502,7 +502,7 @@ export class QueryManager { | |||
|
|
|||
| // If this is not a force fetch, we want to diff the query against the | |||
| // store before we fetch it from the network interface. | |||
| if (!forceFetch) { | |||
| if (fetchType !== FetchType.refetch || !forceFetch) { | |||
There was a problem hiding this comment.
I think it’s correct here to use && and not ||. See if that fixes the tests.
There was a problem hiding this comment.
Thanks -- seems to be passing now. I merged/squashed the commits.
|
Ok - I'll try it out later tonight or tomorrow. Also, any idea why I can't sign the CLA? I keep getting a 500 error when I fill out all the fields. |
|
@stevewillard I just changed some stuff about CLA let me check |
|
Looks like that fixed it. @stevewillard would you be willing to write a test to prevent future regressions? Otherwise it looks good to me 👍 |
|
Hey, sorry about lagging on this PR. I am really swamped with work. I don't think I'll have time for a few weeks to finish this up. Happy to close it out if someone wants to take another stab at it. |
|
I’m comfortable merging this without a test if it is going to be too much effort. @helfer what do you think? |
|
Yeah, that works for me, especially since we might replace |
Fixes #1214