Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make updateQuery option of subscribeToMore optional #1455

Merged
merged 3 commits into from
Mar 21, 2017

Conversation

cesarsolorzano
Copy link
Contributor

@cesarsolorzano cesarsolorzano commented Mar 20, 2017

This patch fix #871 using the recommendations of #879

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@stubailo
Copy link
Contributor

This looks great, just needs a changelog update, and a PR to the docs mentioning that it's optional!

@helfer
Copy link
Contributor

helfer commented Mar 21, 2017

Thanks a lot @cesarsolorzano! Can you do a quick check to see if we also need a PR to the docs?

@helfer helfer merged commit 3ef7cdf into apollographql:master Mar 21, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subscribeToMore should not need a updateQuery function
3 participants