[WIP] reroute npm publish to deploy scripts #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should fix the build on Windows. |
jbaxleyiii
force-pushed
the
error-on-publish
branch
from
326f4be to
316dd94
Compare
jbaxleyiii
changed the title
|
What's the status on this PR? Is there anything I (or someone else) can help with? |
4 tasks
|
Closing in favor of removing the special deploy script as part of #324 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
npm publishis the way to publish instead ofnpm run deployLocally running
npm iwill print outnpm run deploy. This won't actually deploy but is required in order to routenpm publishto our custom script.On the npm shipped version, we remove all of the scripts so
npm run deploywon't happen on anyone else's machine.Fixes #188
.