Add basic interoperability with other Observable implementations #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martijnwalraven hey, I don't know how this happened, but it looks like you skipped the PR checklist, which included "add this to the changelog". Can you please add a changelog entry about this? |
|
@martijnwalraven also, the CI tests didn't pass on this PR. |
|
@stubailo: Sorry I missed the changelog. I've added it to the 0.3.5 section because it was included in that release. The tests passed on the CI but I missed the linter errors. Thanks for fixing these. |
|
Yeah no problem! Next time just wait until Travis is done before merging. |
|
I actually did look at the CI results but figured there was something else wrong because the tests themselves passed. Should have taken a closer look at the logs and spotted the linter errors. |
This was referenced Apr 21, 2022
This was referenced May 14, 2022
This was referenced May 21, 2022
This was referenced May 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149.