Fixed issue with multiple polling queries #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,7 @@ export class QueryManager { | |||
| private networkInterface: NetworkInterface; | |||
| private store: ApolloStore; | |||
| private reduxRootKey: string; | |||
| private pollingTimer: NodeJS.Timer | any; // oddity in typescript | |||
| private pollingTimers: {[queryId: string]: NodeJS.Timer | any}; | |||
There was a problem hiding this comment.
Remind me, why does this have to have an any? If it's an oddity in typescript, maybe we should keep that explanation.
There was a problem hiding this comment.
I don't really know why. I will find out and add in an explanation.
|
This is great! Just wondering if we can cut the time necessary for the test. |
|
@Poincare this is a great improvement |
|
Rebased. |
jbaxleyiii
pushed a commit
that referenced
this pull request
Oct 17, 2017
…bject added docs for default dataIdFromObject selector
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we were using a single timer reference, there were polling leaks when we had multiple polling queries - see #248
This changeset should fix that issue and introduces a unit test that used to fail but now doesn't.
TODO: