await refetched queries before resolve mutation

[jzimmek]

Fixes #1618.
Fixes #1821.
Fixes #3113.

Checklist:

• If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
• Make sure all of the significant new logic is covered by tests
• If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

[apollo-cla]

@jzimmek: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[jzimmek]

this pull request is adressing #1618

[benjamn]

Would it make sense to let these queries run in parallel, rather than awaiting each one after the other?

[benjamn]

One way to avoid this try-catch wrapping would be to use an async helper method:

complete: () => this._completeHelper().then(resolve, reject),
_completeHelper: async () => {
  if (error) {...}
  ...
  return storeResult;
}

[benjamn]

You might want to rebase this PR and add a quick CHANGELOG, just to get those tests passing. Not sure why the bundle size would have changed at all…

[tkapiris]

Any progress on this PR? Tried it myself with some changes (a complete helper async function, an await Promise.all in refetchqueries along with an await in each refetch both with string or document input) and seems to work nicely. Of course it executes the refetches in serial mode.

[hwillson]

Thanks for your work on this @jzimmek!

[hwillson]

We should be all set here, so it's LGTM time.

Quick note - react-apollo should be updated with similar awaitRefetchQueries changes (ideally before these changes get published). I'll try to get those changes in place for tomorrow, so we can release new apollo-client and react-apollo versions together.