-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Optimistic UI #321
[WIP] Optimistic UI #321
Conversation
@davidwoody I would take a look at the Mutation Results PR and design. I think once thats in, we can leverage how the mutation results are applied. And do optimistic UI there. Have you seen it? |
So one thing I think would be really great is if people can write whatever mutation result reducers they want, and then the optimistic UI system still handles it. So ideally the two systems are decoupled, and the optimistic UI part can handle any mutation logic. |
@@ -4,6 +4,7 @@ Expect active development and potentially significant breaking changes in the `0 | |||
|
|||
### vNEXT | |||
|
|||
- Allow `client.mutate` to accept an `optimisticResponse` argument to update the cache immediately, then after the server responds replace the `optimisticResponse` with the real response. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you list the PR and issue numbers and links here?
This is an absolutely awesome start. I think we should run with this idea, and come up with a bunch of test cases for it. We can borrow the tests from this PR: #320 |
@davidwoody I've added you as a contributor on the repo. Would you mind reopening this PR as a branch of the repository? That way I can push to it as well. |
Migrating changes over from PR #321
closing in favor of #336 |
Migrating changes over from PR #321
Migrating changes over from PR #321
Migrating changes over from PR #321
TODO: