Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Optimistic UI #321

Closed
wants to merge 4 commits into from
Closed

Conversation

davidwoody
Copy link
Contributor

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@abhiaiyer91
Copy link
Contributor

@davidwoody I would take a look at the Mutation Results PR and design. I think once thats in, we can leverage how the mutation results are applied. And do optimistic UI there. Have you seen it?
#320

@stubailo
Copy link
Contributor

So one thing I think would be really great is if people can write whatever mutation result reducers they want, and then the optimistic UI system still handles it. So ideally the two systems are decoupled, and the optimistic UI part can handle any mutation logic.

@@ -4,6 +4,7 @@ Expect active development and potentially significant breaking changes in the `0

### vNEXT

- Allow `client.mutate` to accept an `optimisticResponse` argument to update the cache immediately, then after the server responds replace the `optimisticResponse` with the real response.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list the PR and issue numbers and links here?

@stubailo
Copy link
Contributor

This is an absolutely awesome start. I think we should run with this idea, and come up with a bunch of test cases for it. We can borrow the tests from this PR: #320

@stubailo
Copy link
Contributor

@davidwoody I've added you as a contributor on the repo. Would you mind reopening this PR as a branch of the repository? That way I can push to it as well.

@stubailo stubailo changed the title Optimistic UI [WIP] Optimistic UI Jun 28, 2016
davidwoody added a commit that referenced this pull request Jun 29, 2016
Migrating changes over from PR #321
@davidwoody
Copy link
Contributor Author

closing in favor of #336

@davidwoody davidwoody closed this Jun 29, 2016
stubailo pushed a commit that referenced this pull request Jul 1, 2016
Migrating changes over from PR #321
Slava pushed a commit that referenced this pull request Jul 11, 2016
Migrating changes over from PR #321
Slava pushed a commit that referenced this pull request Jul 12, 2016
Migrating changes over from PR #321
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants