Fix typescript issue with defaultOptions in constructor
#3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new `QueryBaseOptions` and `QueryOptions` interfaces were created in eb89b23, `ModifiableWatchQueryOptions` was replaced by `QueryOptions` when checking the `query` `defaultOptions` used in the Apollo Client constructor. Unfortunately, this introduced a small type check bug since the `query` property in `QueryOptions` is a mandatory property, whereas `ModifiableWatchQueryOptions` did not include this property. This commit replaces the use of `QueryOptions` with `QueryBaseOptions` when type checking `query` in `defaultOptions`, since `QueryBaseOptions` doesn't have a `query` property. Fixes #3583.
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new
QueryBaseOptionsandQueryOptionsinterfaces were created ineb89b23,
ModifiableWatchQueryOptionswas replaced byQueryOptionswhen checking thequerydefaultOptionsused in the Apollo Client constructor. Unfortunately, this introduced a small type check bug since thequeryproperty inQueryOptionsis a mandatory property, whereasModifiableWatchQueryOptionsdid not include this property. This commit replaces the use ofQueryOptionswithQueryBaseOptionswhen type checkingqueryindefaultOptions, sinceQueryBaseOptionsdoesn't have aqueryproperty.Fixes #3583.