Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move methods to observable (Issue #194) #362

Merged
merged 7 commits into from
Jul 11, 2016
Merged

Move methods to observable (Issue #194) #362

merged 7 commits into from
Jul 11, 2016

Conversation

amandajliu
Copy link
Contributor

@amandajliu amandajliu commented Jul 6, 2016 •
edited
Loading

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@zol zol added the in progress label Jul 6, 2016
@kamilkisiela kamilkisiela mentioned this pull request Jul 6, 2016
Merged
3 tasks
@kamilkisiela
Copy link
Contributor

kamilkisiela commented Jul 6, 2016 •
edited
Loading

angular2-apollo is ready for this 👍 kamilkisiela/apollo-angular#40

stubailo
stubailo reviewed Jul 6, 2016
View reviewed changes
CHANGELOG.md
@@ -3,6 +3,7 @@
Expect active development and potentially significant breaking changes in the `0.x` track. We'll try to be diligent about releasing a `1.0` version in a timely fashion (ideally within 3 to 6 months), to signal the start of a more stable API.

### vNEXT
- moved refetch(), startPolling(), and stopPolling() methods from QuerySubscription to ObservableQuery [Issue #194] [PR #362]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the links to the issue/PR? It's a bit verbose but it's really helpful to be able to click on them.

@stubailo
Copy link
Contributor

stubailo commented Jul 6, 2016

Looks great so far, just a few comments. The current implementation works well but I think we should reorganize a few things before merging.

@Poincare
Copy link
Contributor

Poincare commented Jul 7, 2016

Since this is also a breaking change, maybe we should release with the error handling change?

@stubailo
Copy link
Contributor

stubailo commented Jul 7, 2016

Agreed!

@stubailo stubailo force-pushed the move-methods-to-observable branch from fd1750f to 2685c38 Compare July 11, 2016 19:22
@stubailo stubailo force-pushed the move-methods-to-observable branch from 2685c38 to 5fc2545 Compare July 11, 2016 19:23
@stubailo stubailo added this to the 0.4.0 breaking changes milestone Jul 11, 2016
@stubailo stubailo merged commit 1604be1 into master Jul 11, 2016
@zol zol removed the in progress label Jul 11, 2016
kamilkisiela added a commit to kamilkisiela/apollo-angular that referenced this pull request Jul 16, 2016
@kamilkisiela
Merge pull request #40 from apollostack/methods-observable
3143269 
Methods moved to an observable apollographql/apollo-client#362
@stubailo stubailo deleted the move-methods-to-observable branch September 20, 2016 03:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0 breaking changes
Development

Successfully merging this pull request may close these issues.
5 participants
@amandajliu @kamilkisiela @stubailo @Poincare @zol