Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct WrappedInstance example in React Apollo docs #3925

Merged
merged 2 commits into from
Sep 18, 2018
Merged

Correct WrappedInstance example in React Apollo docs #3925

merged 2 commits into from
Sep 18, 2018

Conversation

shanonvl
Copy link
Contributor

  • Resolve logic issue ( component.saySomething() should be component.getWrappedInstance().saySomething() )
  • Introduce wrappedInstance constant for clarity

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

- Resolve logic issue ( `component.saySomething()` should be `component.getWrappedInstance().saySomething()` )
- Introduce `wrappedInstance` constant for clarity
@apollo-cla
Copy link

@shanonvl: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shanonvl!

@hwillson hwillson merged commit 5f433f6 into apollographql:master Sep 18, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants