Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add explicit mention of ownProps #4009

Merged
merged 3 commits into from
Jan 2, 2019

Conversation

anand-sundaram-zocdoc
Copy link
Contributor

@anand-sundaram-zocdoc anand-sundaram-zocdoc commented Oct 16, 2018

I noticed while trying to use the graphql() function locally that to access props of the wrapped component in the props function, it's necessary to use the key ownProps like in mapStateToProps in react-redux, but this doesn't seem to be explicitly documented anywhere, so I added it.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes) - not a new feature
  • Make sure all of the significant new logic is covered by tests - no new logic, just docs

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great add - thanks @anand-sundaram-zocdoc!

@hwillson hwillson merged commit 30265c9 into apollographql:master Jan 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants