Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refetch query when get any missing fields on cache #4096

Closed
wants to merge 2 commits into from

Conversation

joe-re
Copy link
Contributor

@joe-re joe-re commented Nov 4, 2018

Fix: #3928

I implemented to refetch when get any missing fields on apollo-cache-inmemory.
I gave refetch logic as callback from apollo-client to apollo-cache-inmemory because refetch is client context. I feel this is needed more discussions..
How do you think?

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@hwillson
Copy link
Member

hwillson commented Jan 2, 2019

Thanks for this PR @joe-re. This has currently been addressed in React Apollo, through the use of the Query component's partialRefetch prop (see the React Apollo Query API docs for more info). We're looking at how refetching is handled across the board, and will be implementing future changes, but for now using partialRefetch will work. Thanks again!

@hwillson hwillson closed this Jan 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data disappears between two queries of the same type. UI updates with empty props.
2 participants