Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some returns to prevent errors with "noImplicitReturns" typescript rule #4137

Merged
merged 6 commits into from
Nov 16, 2018
Merged

Added some returns to prevent errors with "noImplicitReturns" typescript rule #4137

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
152456a
Added some `returns` to prevent errors with typescript rules
Nov 13, 2018
23e25ea
Merge branch 'master' into master
dumaron Nov 15, 2018
f56ffab
Update packages/apollo-cache-inmemory/src/readFromStore.ts
benjamn Nov 16, 2018
2d3a248
Update packages/apollo-cache-inmemory/src/readFromStore.ts
benjamn Nov 16, 2018
b934cf0
Merge branch 'master' into master
dumaron Nov 16, 2018
1f4d164
Merge branch 'master' into master
dumaron Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/apollo-cache-inmemory/src/queryKeyMaker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class PerQueryKeyMaker {
fragment = definition;
return true;
}
return false;
});

// Include the key object computed from the FragmentDefinition named by
Expand Down
2 changes: 2 additions & 0 deletions packages/apollo-cache-inmemory/src/readFromStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ export class StoreReader {
rootValue.id,
);
}
return true;
dumaron marked this conversation as resolved.
Show resolved Hide resolved
}
});

Expand All @@ -149,6 +150,7 @@ export class StoreReader {
rootValue.id,
);
}
return false;
dumaron marked this conversation as resolved.
Show resolved Hide resolved
}
});
}
Expand Down