Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 update local state docs to work with apollo-cli codegen #4187

Merged
merged 3 commits into from
Nov 29, 2018

Conversation

justinanastos
Copy link
Contributor

apollo client:codegen only looks inside gql tags. We need to use gql for the client-side schema so that the codegen validator will recognize the schema at all.

This will update the apollo-client docs so that they'll be compatible with codegen.

[`apollo
client:codegen`](https://github.com/apollographql/apollo-tooling#apollo-clientcodegen-output)
only looks inside `gql` tags. We need to use `gql` for the client-side
schema so that the codegen validator will recognize the schema at all.

This will update the apollo-client docs so that they'll be compatible with
codegen.
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome catch @justinanastos - thanks!

@hwillson hwillson merged commit f89700c into master Nov 29, 2018
@hwillson hwillson deleted the justin/docs/local-state-schema branch November 29, 2018 10:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants