Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable query diffing #43

Merged
merged 14 commits into from
Mar 28, 2016
Merged

Enable query diffing #43

merged 14 commits into from
Mar 28, 2016

Conversation

stubailo
Copy link
Contributor

Working on implementing #42, looking for feedback on the design there! Not ready for feedback on the implementation though.

Todo

  • Make query diffing actually output one query with all of the different nodes required
  • Make query diffing use variables where the original query used variables
  • Call the query diff function inside QueryManager when the appropriate option is passed
  • Make sure to handle the case where the server doesn't implement the Relay ID spec

@stubailo stubailo mentioned this pull request Mar 27, 2016
@stubailo stubailo force-pushed the enable-diffing branch 2 times, most recently from 0a4423c to 7b06150 Compare March 28, 2016 02:32
@stubailo stubailo changed the title [WIP] enable query diffing Enable query diffing Mar 28, 2016
@stubailo
Copy link
Contributor Author

Going to merge this and file some issues for the TODOs.

@stubailo
Copy link
Contributor Author

Sigh, tired of waiting for AppVeyor.

@stubailo stubailo merged commit 605208d into master Mar 28, 2016
@jbaxleyiii
Copy link
Contributor

@stubailo yeah 👎 I've found appveyor to be really slow. I wonder if we can make that one CI not required? Or remove it?

@stubailo
Copy link
Contributor Author

Ooh, maybe we can set it only for master. Let me check.

@stubailo
Copy link
Contributor Author

OK it should only build master now. So we'll find out after the fact if we broke Windows, which is fine since it will probably be relatively rare.

@stubailo stubailo deleted the enable-diffing branch April 2, 2016 20:28
jbaxleyiii pushed a commit that referenced this pull request Oct 18, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants