Support ApolloClient#stop for safe client disposal. #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by apollographql/react-apollo#2738, it should be possible to shut down an ApolloClient instance without making assumptions about its implementation details. This client.stop() method should also be useful for server-side rendering, where you're supposed to create (and throw away) a new ApolloClient instance for each request. I'm not entirely sure this implementation cleans up everything that might need to be cleaned up, but I am sure it's better than nothing.
hwillson
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Looks great @benjamn! This should definitely help. I know we're moving quick to address apollographql/react-apollo#2738, but we'll want to circle back here to get some tests and API docs changes in place. I'll make a note. Thanks!
benjamn
added a commit
to apollographql/react-apollo
that referenced
this pull request
Jan 19, 2019
This method was introduced in apollo-client@2.4.12: apollographql/apollo-client#4336
benjamn
added a commit
that referenced
this pull request
Jan 19, 2019
This reverts commit 9739ff6. Now that we have a uniform interface for terminating ApolloClient instances (#4336), there should be no need for any external code to access the QueryScheduler abstraction, which this commit removes. We should wait to merge and release this change until after apollographql/react-apollo#2741 has been merged and released, so that we don't break older versions of MockedProvider.
| // After calling this.stopPollingQuery for all registered queries, calling | ||
| // fetchQueriesOnInterval will remove the corresponding intervals. | ||
| Object.keys(this.intervalQueries).forEach(interval => { | ||
| this.fetchQueriesOnInterval(+interval); |
There was a problem hiding this comment.
@benjamn Why is there a + before interval?
|
Awesome! |
benjamn
added a commit
to apollographql/react-apollo
that referenced
this pull request
Jan 19, 2019
This method was introduced in apollo-client@2.4.12: apollographql/apollo-client#4336
benjamn
added a commit
that referenced
this pull request
Jan 22, 2019
This reverts commit 9739ff6. Now that we have a uniform interface for terminating ApolloClient instances (#4336), there should be no need for any external code to access the QueryScheduler abstraction, which this commit removes. We should wait to merge and release this change until after apollographql/react-apollo#2741 has been merged and released, so that we don't break older versions of MockedProvider.
benjamn
added a commit
that referenced
this pull request
Jan 22, 2019
This reverts commit 9739ff6. Now that we have a uniform interface for terminating ApolloClient instances (#4336), there should be no need for any external code to access the QueryScheduler abstraction, which this commit removes. We should wait to merge and release this change until after apollographql/react-apollo#2741 has been merged and released, so that we don't break older versions of MockedProvider.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by apollographql/react-apollo#2738, it should be possible to shut down an
ApolloClientinstance without making assumptions about its implementation details.This
client.stop()method should also be useful for server-side rendering, where you're supposed to create (and throw away) a newApolloClientinstance for each request.I'm not entirely sure this implementation cleans up everything that might need to be cleaned up, but I am sure it's better than nothing.