Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify building the graphql-anywhere/lib/async entry point. #4503

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

benjamn
Copy link
Member

@benjamn benjamn commented Feb 26, 2019

Should fix apollographql/apollo-link-rest#194.

In graphql-anywhere@4.2.0, the graphql-anywhere/lib/async.js module accidentally disappeared, with graphql-anywhere/lib/async.cjs.js in its place.

Whatever you may think about the wisdom of sub-module imports, graphql-anywhere/lib/async was expected to exist by other packages like apollo-link-state, so we should fix it.

This commit removes the special Rollup step for async.cjs.js and renames src/graphql-async.ts to just src/async.ts so that tsc will output graphql-anywhere/lib/async.js as CommonJS, as desired.

@benjamn benjamn added this to the Release 2.5.0 milestone Feb 26, 2019
@benjamn benjamn self-assigned this Feb 26, 2019
@benjamn benjamn requested a review from hwillson February 26, 2019 22:31
@benjamn benjamn merged commit a440242 into master Feb 26, 2019
@benjamn benjamn deleted the fix-graphql-anywhere/lib/async branch February 26, 2019 22:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issues when upgrading to Apollo Client 2.5
1 participant