Pass context from subscriptions through to links #4925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgtpepper43: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
sgtpepper43
commented
Jun 5, 2019
karice
approved these changes
Jan 31, 2020
hwillson
force-pushed
the
context-in-subscriptions
branch
from
027dda5 to
24be8fa
Compare
hwillson
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Thanks very much for your initial work on this @sgtpepper43!
@benjamn we should be all set here, but let me know if I should go ahead and merge or if you would prefer to wait until after your recent large round of refactoring is in place.
Makes sure a supplied `context` object is passed through the link execution chain, when set in `client.subscribe` options.
hwillson
force-pushed
the
context-in-subscriptions
branch
from
24be8fa to
867ca5f
Compare
|
@hwillson any ETA when will this be released? |
|
@promontis It will be available in the next RC release, which will probably be later today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves apollographql/apollo-feature-requests#93
Allow a context to be supplied when creating subscriptions, and pass that context through to the links.
There are a bunch of other changes in here that I'm pretty sure was made by the linter or prettier or whatever you've got going. Some pre-commit hook that automatically ran. I'll mark those changes and I can get rid of them if you want.
Checklist: