-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add graphql as a peerDependency of apollo-cache and graphql-anywhere. #5081
Add graphql as a peerDependency of apollo-cache and graphql-anywhere. #5081
Conversation
@ssalbdivad: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
@benjamn Any updates on this? Seems like a fairly straightforward fix that unblocks folks using pnpm from using apollo-client and makes apollo-cache and graphql-anywhere consistent with a dependency management strategy that has already been established in all other apollo-client packages. |
@benjamn ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @ssalbdivad and sorry for the delay.
This change has been merged but not released yet, so the problem is still present 🙂 |
Currently both apollo-cache and graphql-anywhere depend on graphql but do not list it in their dependencies. This change makes apollo-cache and graphql-anywhere consistent with the other packages in apollo-client that depend on graphql by listing it as a peer dependency with a major version between 11 and 14.
This also allows pnpm and other package managers with stricter dependency management requirements to install a working version of apollo-client out of the box.